Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Handling #699

Closed
blink1073 opened this issue Feb 15, 2022 · 0 comments · Fixed by #707
Closed

Dependency Handling #699

blink1073 opened this issue Feb 15, 2022 · 0 comments · Fixed by #707

Comments

@blink1073
Copy link
Contributor

blink1073 commented Feb 15, 2022

Description

After reading this blog post, I'm convinced that we should not be using upper bound constraints for our dependencies.

tl;dr It is much more of a headache for users if libraries add upper version constraints. The author gives in depth reasons and suggested ways to avoid upper version constraints.

Proposal

  • Remove all upper version constraints (< and ~).
  • Add a job that installs with --pre and runs our tests
  • Do not merge a PR that causes the --pre job to fail
  • Try not to release with a failing --pre job
  • Add config to run pytest with filterwarnings=error
  • Add a cron config to our workflows to make sure they run nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant