Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds are failing the culling test #5

Closed
blink1073 opened this issue Jan 27, 2022 · 2 comments · Fixed by #6 or #7
Closed

Windows builds are failing the culling test #5

blink1073 opened this issue Jan 27, 2022 · 2 comments · Fixed by #6 or #7
Labels
bug Something isn't working

Comments

@blink1073
Copy link
Contributor

blink1073 commented Jan 27, 2022

Description

I reran https://github.com/jupyter-server/jupyter_server_terminals/runs/4960949698?check_suite_focus=true, which had originally passed. It might be related to the 2.0.1 pywinpty release.

I confirmed that pinning to pywintpy<2 allows us to cull again. Merging #6 with a workaround for now.

@blink1073 blink1073 added the bug Something isn't working label Jan 27, 2022
@welcome
Copy link

welcome bot commented Jan 27, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@blink1073
Copy link
Contributor Author

The difference is that we are not triggering an eof on the pty. In the working version, we get the logs:

INFO     ServerApp:management.py:217 EOF on FD 1360; stopping reading
INFO     ServerApp:management.py:382 Terminal 1 closed

management.py is in terminado. I'm going to look into adding a test to terminado that fails, and try and address the issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant