Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video2x-qt6] packaging on Arch #1274

Closed
3 tasks done
Misaka13514 opened this issue Dec 24, 2024 · 11 comments
Closed
3 tasks done

[video2x-qt6] packaging on Arch #1274

Misaka13514 opened this issue Dec 24, 2024 · 11 comments
Labels
state:Done This issue has been resolved/dismissed

Comments

@Misaka13514
Copy link

Misaka13514 commented Dec 24, 2024

Package version:

video2x-git 6.3.1.r12.g2cfdb69-1
video2x-qt6-git 6.3.1.r8.gcb7492c-1
  • Translation files should be installed and loaded
  • Freedesktop icon is not shown on GNOME, is this just me or fix needed?
  • clang should be added to makedepends
@k4yt3x k4yt3x transferred this issue from k4yt3x/video2x-qt6 Dec 24, 2024
@github-actions github-actions bot added the state:Backlog This issue will be worked on in the future label Dec 24, 2024
@k4yt3x k4yt3x added component:GUI state:InProgress This issue is being worked on and removed state:Backlog This issue will be worked on in the future labels Dec 24, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Dec 25, 2024

Yeah you're right, the translation files should be installed. I'll need to check how and where they should be installed.

@Misaka13514 Misaka13514 changed the title Packaging on Arch [video2x-qt6] packaging on Arch Dec 25, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Dec 27, 2024

I think I fixed it in this commit: k4yt3x/video2x-qt6@d365597. I'll do some more tests.

@Misaka13514
Copy link
Author

I have confirmed changeLanguage working on 6.3.1.r9.gd365597-1, thank you!

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 28, 2024

clang added to makedepends.

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 28, 2024

As for the last issue with the icon, I checked and it seems to be compliant with XDG standards:

./
└── video2x-qt6/
    └── usr/
        ├── bin/
        │   └── video2x-qt6*
        └── share/
            ├── applications/
            │   └── video2x-qt6.desktop
            ├── icons/
            │   └── hicolor/
            │       └── 1024x1024/
            │           └── apps/
            │               └── video2x.png
            └── licenses/
                └── video2x-qt6/
                    └── LICENSE

I'm not sure what else is needed for it to display correctly. I'm using i3 with rofi right now and I can't see icons.

@Misaka13514
Copy link
Author

Maybe try adding more resolutions or try using absolute path to the icon

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 28, 2024

The standard 1024x1024 resolution should work, and I don't think absolute path in the desktop file is standard practice. The main issue here is that I can't confirm the change works. rofi doesn't display icons. I'll need a VM or someone else to confirm it.

@Misaka13514
Copy link
Author

Misaka13514 commented Dec 28, 2024

I can test it for you, just send me the PKGBUILD :)

I can resize the icon and make a PR if you want

@Misaka13514
Copy link
Author

Screenshot From 2024-12-28 20-20-24

The icon is not showed on KDE either according to my test in a VM

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 28, 2024

Can you please try the newest video2x-qt6-git? I've updated more icon resolutions and it seems to work.
I think the issue is that KDE doesn't look for 1024x1024. When I added 256x256 it shows up fine.

@Misaka13514
Copy link
Author

It works, thank you!

@github-actions github-actions bot added state:Done This issue has been resolved/dismissed and removed state:InProgress This issue is being worked on labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:Done This issue has been resolved/dismissed
Projects
None yet
Development

No branches or pull requests

2 participants