From a747f70419fadc2eb6a4513af33bcb35dd620b7f Mon Sep 17 00:00:00 2001 From: Yair Ansbacher Date: Sun, 6 Dec 2020 09:10:08 +0200 Subject: [PATCH] fix(FEC-10749): playlist by sources stuck (#386) Issue: #370 [moved](https://github.com/kaltura/kaltura-player-js/pull/370/files#diff-b20fda8cac0288af75e0f3c4304df5420584de585d923934f9606e3634d2dbf5L302) the redirect default settings from `setup` to `loadMedia` so `sources` could be `undefined` in kaltura-player constructor Solution: pass empty object to `sources` to the local player if it's `undefined` Solves FEC-10749 --- src/kaltura-player.js | 2 +- test/src/kaltura-player.spec.js | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/kaltura-player.js b/src/kaltura-player.js index 3b27926bc..6dd72b9eb 100644 --- a/src/kaltura-player.js +++ b/src/kaltura-player.js @@ -75,7 +75,7 @@ class KalturaPlayer extends FakeEventTarget { Object.values(CoreEventType).forEach(coreEvent => this._eventManager.listen(this._localPlayer, coreEvent, e => this.dispatchEvent(e))); this._addBindings(); this._playlistManager.configure(options.playlist); - this._localPlayer.configure({sources}); + this._localPlayer.configure({sources: sources || {}}); } /** diff --git a/test/src/kaltura-player.spec.js b/test/src/kaltura-player.spec.js index c4c74b4f0..cc8f7a951 100644 --- a/test/src/kaltura-player.spec.js +++ b/test/src/kaltura-player.spec.js @@ -41,6 +41,18 @@ describe('kaltura player api', function () { TestUtils.removeElement(targetId); }); + describe('constructor', function () { + beforeEach(function () { + kalturaPlayer = setup(config); + }); + + afterEach(function () { + kalturaPlayer.destroy(); + }); + it('config.sources should be an empty object if no configured', function () { + kalturaPlayer.config.sources.should.be.exist; + }); + }); describe('media api', function () { describe('loadMedia', function () { const entryId = '0_wifqaipd'; @@ -614,6 +626,7 @@ describe('kaltura player api', function () { }); }); }); + describe('async plugins loading', () => { let player; beforeEach(() => {