From c1ac3fe0c9cdbec29e97079fe59ddfa62a8bec83 Mon Sep 17 00:00:00 2001 From: Yair Ansbacher Date: Tue, 2 Feb 2021 13:09:37 +0200 Subject: [PATCH] feat(FEC-10961): show the thumbnail preview in live (#407) Don't build the default thumbnail preview for live content Solves FEC-10961 --- src/common/utils/thumbs.js | 4 +++- test/src/common/utils/thumbs.spec.js | 9 ++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/common/utils/thumbs.js b/src/common/utils/thumbs.js index 380a82fa2..72098b3ea 100644 --- a/src/common/utils/thumbs.js +++ b/src/common/utils/thumbs.js @@ -1,5 +1,6 @@ // @flow import evaluate from './evaluate'; +import {MediaType} from '@playkit-js/playkit-js'; export const DEFAULT_THUMBS_WIDTH: number = 164; export const DEFAULT_THUMBS_SLICES: number = 100; @@ -16,7 +17,8 @@ const TEMPLATE: string = '{{thumbnailUrl}}/width/{{width}}/vid_slices/{{slices}} */ export function getThumbSlicesUrl(mediaConfig: KPMediaConfig, seekbarConfig?: SeekbarConfig): string { const mediaConfigPoster = mediaConfig.sources && mediaConfig.sources.poster; - if (typeof mediaConfigPoster === 'string') { + const isVod = mediaConfig.sources && mediaConfig.sources.type === MediaType.VOD; + if (typeof mediaConfigPoster === 'string' && isVod) { if (THUMBNAIL_REGEX.test(mediaConfigPoster)) { try { const model: Object = { diff --git a/test/src/common/utils/thumbs.spec.js b/test/src/common/utils/thumbs.spec.js index 7a86c6ad9..ece99f4a4 100644 --- a/test/src/common/utils/thumbs.spec.js +++ b/test/src/common/utils/thumbs.spec.js @@ -1,9 +1,11 @@ import {getThumbSlicesUrl} from '../../../../src/common/utils/thumbs'; +import {MediaType} from '@playkit-js/playkit-js'; describe('getThumbSlicesUrl', function () { const fakeData = { sources: { - poster: '//my-thumb-service.com/p/1/thumbnail/entry_id/2/version/3' + poster: '//my-thumb-service.com/p/1/thumbnail/entry_id/2/version/3', + type: MediaType.VOD }, session: { ks: 'my-ks' @@ -32,4 +34,9 @@ describe('getThumbSlicesUrl', function () { fakeData.sources.poster = '//my-thumb-service.com/p/1/entry_id/2/version/3'; getThumbSlicesUrl(fakeData, fakeUIConfig).should.equals(``); }); + + it('should get empty thumbnail slices url for live content', function () { + fakeData.sources.type = MediaType.LIVE; + getThumbSlicesUrl(fakeData, fakeUIConfig).should.equals(``); + }); });