Skip to content

Commit fcb6dc5

Browse files
viankakrisnagaearon
authored andcommitted
run npm 5.4.0 in CI (facebook#3026)
* run npm 5.4.0 in CI * run npm cache clean with --force in CI * use link instead of install * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh
1 parent 634dadb commit fcb6dc5

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

tasks/e2e-installs.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,11 @@ fi
9595

9696
if hash npm 2>/dev/null
9797
then
98-
# npm 5 is too buggy right now
98+
# npm 5.0-5.4.0 is too buggy
9999
if [ $(npm -v | head -c 1) -eq 5 ]; then
100-
npm i -g npm@^4.x
100+
npm i -g npm@^5.4.1
101101
fi;
102-
npm cache clean || npm cache verify
102+
npm cache clean --force || npm cache verify
103103
fi
104104

105105
# Prevent bootstrap, we only want top-level dependencies

tasks/e2e-kitchensink.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@ fi
8787

8888
if hash npm 2>/dev/null
8989
then
90-
# npm 5 is too buggy right now
90+
# npm 5.0-5.4.0 is too buggy
9191
if [ $(npm -v | head -c 1) -eq 5 ]; then
92-
npm i -g npm@^4.x
92+
npm i -g npm@^5.4.1
9393
fi;
94-
npm cache clean || npm cache verify
94+
npm cache clean --force || npm cache verify
9595
fi
9696

9797
# Prevent bootstrap, we only want top-level dependencies

tasks/e2e-simple.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,11 @@ fi
8686

8787
if hash npm 2>/dev/null
8888
then
89-
# npm 5 is too buggy right now
89+
# npm 5.0-5.4.0 is too buggy
9090
if [ $(npm -v | head -c 1) -eq 5 ]; then
91-
npm i -g npm@^4.x
91+
npm i -g npm@^5.4.1
9292
fi;
93-
npm cache clean || npm cache verify
93+
npm cache clean --force || npm cache verify
9494
fi
9595

9696
# Prevent bootstrap, we only want top-level dependencies

0 commit comments

Comments
 (0)