fix: only fire onToggle on external props change if it's different to…

… internal on state to avoid double firing (#19)

src/__tests__/index.js

@@ -170,13 +170,14 @@ test('onToggle gets called with fresh state in controlled prop scenario', () =>
   expect(spy.mock.calls.length).toBe(1)
 })
 
-test('onToggle gets called when setOnState is called in controlled prop scenario', () => {
+test('onToggle gets called on internal state change in controlled prop scenario', () => {
   const spy = jest.fn()
-  const {setOn, setOff} = setup({on: false, onToggle: spy})
+  const {setOn, setOff, wrapper} = setup({on: false, onToggle: spy})
   setOff()
   expect(spy).not.toHaveBeenCalled()
   setOn()
   expect(spy).toHaveBeenLastCalledWith(true, expect.anything())
+  wrapper.setProps({on: true})
   expect(spy.mock.calls.length).toBe(1)
 })
 

src/index.js

@@ -79,11 +79,9 @@ class Toggle extends Component {
   setOff = this.setOnState.bind(this, false)
   toggle = this.setOnState.bind(this, undefined)
 
-  componentDidUpdate(prevProps, prevState) {
-    const on = this.getOn()
-
-    if (this.getOn(prevState, prevProps) !== on) {
-      this.props.onToggle(on, this.getTogglerStateAndHelpers())
+  componentWillReceiveProps(newProps) {
+    if (newProps.on !== this.props.on && newProps.on !== this.state.on) {
+      this.setOnState(newProps.on)
     }
   }