NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1578 +/- ##
============================================
+ Coverage 76.66% 76.72% +0.05%
- Complexity 1600 1611 +11
============================================
Files 355 356 +1
Lines 14882 14918 +36
Branches 1675 1680 +5
============================================
+ Hits 11410 11446 +36
+ Misses 2583 2580 -3
- Partials 889 892 +3
Continue to review full report at Codecov.
|
Arkariang
reviewed
Mar 24, 2022
Arkariang
reviewed
Mar 24, 2022
Arkariang
reviewed
Mar 24, 2022
| * @param initialValue Value to convert, local to the project's currency. | ||
| * @param roundingMode When this is DOWN, we get the floor of the initialValue. | ||
| */ | ||
| private fun getRoundedValue(initialValue: Double, roundingMode: RoundingMode): Float { |
There was a problem hiding this comment.
This method can be private to KSCurrency class, no need for it to be wrapped on a companion object
leighdouglas
force-pushed
the
leigh/ntv-381-kscurrency-parcelize
branch
from
d36198f to
9f3dd90
Compare
Arkariang
added a commit
that referenced
this pull request
Apr 6, 2022
…e/NTV-411-integrate-payment-sheet * 'master' of github.com:kickstarter/android-oss: (22 commits) NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592) NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591) NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590) NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589) NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588) NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586) NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585) NTV-465: Add audio parsing (#1584) NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580) NTV-438: Deprecate autoparcel for checkout (#1583) NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578) NTV-463: Crash during regression (#1582) [no-jira]: update dependencies (#1579) NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581) NTV-441 : Migrat Video.java to kotlin and deprecate Autoparcel (#1577) NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576) NTV-456: Ktlint integration update (#1575) NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569) NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570) Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
KSCurrency.javato kotlinCurrencyOptionsparcelable fromKSCurrency🤔 Why
Deprecation of
autoparcellibrary in an ongoing effort to migrate to android's in-houseparcelize.📋 QA
Story 📖
NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel
WEB-376: Migrate KSCurrency to kotlin and deprecate autoparcel