Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-438: Deprecate autoparcel for checkout #1583

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 28, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

device-2022-03-28-210736.mp4

📋 QA

test backing project

Story 📖

https://kickstarter.atlassian.net/browse/NTV-438

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1583 (2e482fc) into master (db0be1d) will increase coverage by 0.03%.
The diff coverage is 91.80%.

@@             Coverage Diff              @@
##             master    #1583      +/-   ##
============================================
+ Coverage     76.71%   76.75%   +0.03%     
- Complexity     1610     1618       +8     
============================================
  Files           356      356              
  Lines         14918    14960      +42     
  Branches       1680     1686       +6     
============================================
+ Hits          11445    11482      +37     
  Misses         2580     2580              
- Partials        893      898       +5     
Impacted Files Coverage Δ
...p/src/main/java/com/kickstarter/models/Checkout.kt 90.38% <90.38%> (-9.62%) ⬇️
...ckstarter/mock/factories/CheckoutBackingFactory.kt 100.00% <100.00%> (ø)
.../com/kickstarter/mock/factories/CheckoutFactory.kt 100.00% <100.00%> (ø)
...main/java/com/kickstarter/models/SurveyResponse.kt 89.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0be1d...2e482fc. Read the comment docs.

@Arkariang Arkariang changed the title Hadia/ntv 438 deprecate autoparcel for checkout NTV-438: Deprecate autoparcel for checkout Mar 28, 2022
@hadia hadia merged commit 15f0ded into master Mar 29, 2022
@hadia hadia deleted the hadia/NTV-438_Deprecate_Autoparcel_for_Checkout branch March 29, 2022 09:05
Arkariang added a commit that referenced this pull request Apr 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants