[🔢] Unseen activity count #533
Conversation
Created resuable styles for drawer items with counts.
> Refreshing user after clearing unseen activity. > Tests.
| .compose(bindToLifecycle()) | ||
| .subscribe(this.surveys); | ||
|
|
||
| loggedInUser | ||
| .compose(takeWhen(refreshSurvey)) |
There was a problem hiding this comment.
Just curious why this is called refreshSurvey?
There was a problem hiding this comment.
not sure, I think a better name could be resumeOrRefresh
| .switchMap(__ -> this.apolloClient.clearUnseenActivity().compose(neverError())) | ||
| .switchMap(__ -> this.apiClient.fetchCurrentUser().compose(neverError())) | ||
| .compose(bindToLifecycle()) | ||
| .subscribe(freshUser -> this.currentUser.refresh(freshUser)); |
There was a problem hiding this comment.
So just to confirm I am reading this correctly:
- User refreshes feed.
- Take the current user and inspect their
unseenActivityCount. - If this is not zero, clear the activity count and refresh the user.
I guess the only edge-case race condition is if, between the user logging in and looking at the feed, new activities come in. Would they be alerted to this by the OS via the push notification in some way? I'm also kind've wondering how to handle this on iOS 🤔
There was a problem hiding this comment.
Yeah that's how it works. And hmm, they would get the push but no, we don't refresh the users on pushes. Should I maybe do a combineLatest like
refreshSurvey
. combineLatest(currentUser)
.filter(ObjectUtils::isNotNull)
//do the check and refresh
?
There was a problem hiding this comment.
Ooh also I think the situation with log in would be.
They're logged out.
They log in.
loggedInUser emits.
They return to that screen. onResume is fired (a lifecycle method).
So we'd have the updated user.
But that only handles log in, not getting pushes or new activity while on that screen.
There was a problem hiding this comment.
I think if a push comes in while the user is in the app we should refresh the count, but if the user is on the activities view while that happens then I guess we can ignore it, seeing as we'd have to immediately clear it again.
There was a problem hiding this comment.
Spoke to @nnekab! She said for now, Android doesn't need to update the count after a push comes in because you can't actually see the number on that screen. It's only in the drawer in Discovery.
What ❓
clearUserUnseenActivitymutation.How to QA? 🤔
Well, if you have some unseen activity, the drawer hamburger should show and indicator and the Activity row in the drawer should show the count.
Story 📖
Trello Story
See 👀
I had the foresight to take a screenshot before I cleared it 😎
