Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mulitprocessing support for GPy and sklearn #41

Merged
merged 4 commits into from
Oct 18, 2020

Conversation

kjappelbaum
Copy link
Collaborator

@kjappelbaum kjappelbaum commented Oct 18, 2020

  • implements multiprocessing support for GPy and sklearn (models for different objectives can be trained in parallel by setting n_jobs in the class initialization)
  • added note in docs about the design pattern for implementing concurrent operations
  • for coregionalized models this does not make sense

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Actions (for code changes)

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

Kevin M. Jablonka added 2 commits October 18, 2020 12:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…docs, #36
@kjappelbaum kjappelbaum linked an issue Oct 18, 2020 that may be closed by this pull request
@kjappelbaum kjappelbaum linked an issue Oct 18, 2020 that may be closed by this pull request
@kjappelbaum kjappelbaum changed the title Mulitprocessing Implement mulitprocessing support for GPy and sklearn Oct 18, 2020
@kjappelbaum
Copy link
Collaborator Author

kjappelbaum commented Oct 18, 2020

Codecov Report

Merging #41 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   96.68%   96.84%   +0.15%     
==========================================
  Files          10       10              
  Lines         574      603      +29     
==========================================
+ Hits          555      584      +29     
  Misses         19       19              
Flag Coverage Δ
#unittests 96.84% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pypal/pal/pal_gpy.py 100.00% <100.00%> (ø)
pypal/pal/pal_sklearn.py 100.00% <100.00%> (ø)
pypal/pal/validate_inputs.py 93.25% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ee2ce...f3d9fcb. Read the comment docs.

@kjappelbaum kjappelbaum merged commit 7152ab8 into master Oct 18, 2020
@kjappelbaum kjappelbaum deleted the mulitprocessing branch October 18, 2020 12:23
kjappelbaum added a commit that referenced this pull request Oct 18, 2020
* feat: first multiprocessing implementation for sklearn, #36

* feat: first multiprocessing implementation for GPy and added note in docs, #36

* fix: more restarts for sklearn

* chore: fix random seed for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiprocessing for GP training
1 participant