From aea2cd3ab4bd7faff9a9aea09858bf6fe5c36ec4 Mon Sep 17 00:00:00 2001 From: tetsuo Date: Wed, 10 Dec 2014 23:47:58 +0200 Subject: [PATCH 1/2] ListView: add missing addItemView method --- src/components/list/listview.coffee | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/components/list/listview.coffee b/src/components/list/listview.coffee index 305a7e13..b2282bd8 100755 --- a/src/components/list/listview.coffee +++ b/src/components/list/listview.coffee @@ -49,6 +49,15 @@ module.exports = class KDListView extends KDView return sanitizedIndex + addItemView: (itemInstance, index) -> + + index = @sanitizeIndex index + + @insertItemAtIndex itemInstance, index + + return itemInstance + + addItem: (itemData, index) -> index = @sanitizeIndex index @@ -235,6 +244,7 @@ module.exports = class KDListView extends KDView else @isScrollAtBottom scrollView else no + isScrollAtBottom: (scrollView) -> slidingView = scrollView.find('> .kdview')[0] From 53908b11fcb36296e15889a6570ea0dc2efd4642 Mon Sep 17 00:00:00 2001 From: tetsuo Date: Wed, 10 Dec 2014 23:49:56 +0200 Subject: [PATCH 2/2] AutoCompleteController: use addItemView for adding View instances --- src/components/autocomplete/autocompletecontroller.coffee | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/autocomplete/autocompletecontroller.coffee b/src/components/autocomplete/autocompletecontroller.coffee index 1321eb1b..e70a87a5 100755 --- a/src/components/autocomplete/autocompletecontroller.coffee +++ b/src/components/autocomplete/autocompletecontroller.coffee @@ -178,7 +178,7 @@ module.exports = class KDAutoCompleteController extends KDViewController inexactMatches.push datum if (@dropdownPrefix.length >= minSuggestionLength) and allowNewSuggestions and not exactMatches.length - @dropdown.getListView().addItem @getNoItemFoundView() + @dropdown.getListView().addItemView @getNoItemFoundView() data = exactMatches.concat inexactMatches @dropdown.instantiateListItems data @@ -385,7 +385,7 @@ module.exports = class KDAutoCompleteController extends KDViewController list = @dropdown.getListView() @dropdown.removeAllItems() - list.addItem new fetchingItemClass {}, {} + list.addItemView new fetchingItemClass {}, {} @showDropdown() getNoItemFoundView: (suggestion) -> @@ -403,7 +403,7 @@ module.exports = class KDAutoCompleteController extends KDViewController noItemFoundView = @getNoItemFoundView() @dropdown.removeAllItems() - @dropdown.getListView().addItem noItemFoundView + @dropdown.getListView().addItemView noItemFoundView @showDropdown() destroy:->