From 211143ce363bfd7093b7fe40d0b1fbcdf1953647 Mon Sep 17 00:00:00 2001 From: Sinan Yasar Date: Sun, 25 Dec 2016 20:14:10 +0700 Subject: [PATCH 1/3] ability to add kdview in any element --- lib/core/view.coffee | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/core/view.coffee b/lib/core/view.coffee index fbd182c7..6536492b 100644 --- a/lib/core/view.coffee +++ b/lib/core/view.coffee @@ -59,12 +59,14 @@ module.exports = class KDView extends KDObject objects.overrider[title] = item objects.overrider - appendToDomBody: -> + appendToParentElement: (parent) -> @parentIsInDom = yes unless @lazy - $("body").append @$() + $(parent).append @$() @utils.defer => @emit "viewAppended" + appendToDomBody: -> @appendToParentElement document.body + # # # INSTANCE LEVEL # # @@ -919,4 +921,4 @@ module.exports = class KDView extends KDObject windowController = KD.getSingleton 'windowController' windowController.setKeyView null - activateKeyView: -> @emit? 'KDViewBecameKeyView' \ No newline at end of file + activateKeyView: -> @emit? 'KDViewBecameKeyView' From e9ae55c5e9aed1fff9c161f26168af8820495a00 Mon Sep 17 00:00:00 2001 From: Sinan Yasar Date: Tue, 27 Dec 2016 13:08:24 +0700 Subject: [PATCH 2/3] shims: dropped browser field so that it can be used in node.js env --- lib/components/loader/loaderview.coffee | 2 +- lib/core/view.coffee | 2 +- package.json | 4 ---- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/components/loader/loaderview.coffee b/lib/components/loader/loaderview.coffee index 0088bdd3..644087ff 100644 --- a/lib/components/loader/loaderview.coffee +++ b/lib/components/loader/loaderview.coffee @@ -1,4 +1,4 @@ -require 'canvas-loader' +require 'kd-shim-canvas-loader' KDView = require '../../core/view' module.exports = class KDLoaderView extends KDView diff --git a/lib/core/view.coffee b/lib/core/view.coffee index 6536492b..e9d862dc 100644 --- a/lib/core/view.coffee +++ b/lib/core/view.coffee @@ -2,7 +2,7 @@ debug = require('debug') 'kd:view' $ = require 'jquery' KD = require './kd' KDObject = require './object' -MutationSummary = require 'mutation-summary' +MutationSummary = require 'kd-shim-mutation-summary' module.exports = class KDView extends KDObject diff --git a/package.json b/package.json index fe1de4c4..43a0e036 100644 --- a/package.json +++ b/package.json @@ -57,9 +57,5 @@ "stylus": "^0.54.5", "uglify-js": "^2.7.3", "watchify": "^3.7.0" - }, - "browser": { - "canvas-loader": "kd-shim-canvas-loader", - "mutation-summary": "kd-shim-mutation-summary" } } From ea4d6e6b501843f856ab9194bcc3b2c60f1e5c37 Mon Sep 17 00:00:00 2001 From: Sinan Yasar Date: Tue, 27 Dec 2016 13:09:23 +0700 Subject: [PATCH 3/3] npm: version bump up --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 43a0e036..26cd9e70 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "kd.js", - "version": "1.1.27", + "version": "1.1.28", "description": "a collection of ui widgets and other nice things", "main": "build/lib/index.js", "scripts": {