Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship free-threaded (cp313t) wheels #226

Open
ngoldbaum opened this issue Jan 22, 2025 · 3 comments
Open

Ship free-threaded (cp313t) wheels #226

ngoldbaum opened this issue Jan 22, 2025 · 3 comments
Labels
enhancement New feature or request python

Comments

@ngoldbaum
Copy link
Contributor

It looks like you've already updated to PyO3 0.23, so all that's left is adding CI on the free-threaded interpreter, adding testing for thread safety, and fixing any issues that are discovered in the process.

There is some multithreaded testing and functionality on the rust side, but it looks like there isn't any testing of using kornia-py from the Python threading module.

I'm a PyO3 maintainer and helped lead the effort to ship support for free-threaded python in PyO3 0.23. I'm also actively working on ecosystem support for free-threaded Python as part of my job at quansight labs.

All that to say that I'm happy to do all the heavy lifting here, I'd just appreciate being able to ask questions and get code review.

@edgarriba
Copy link
Member

hi @ngoldbaum thanks for reaching out ! Would be awesome if you could lead that part. I've been recently focusing more on the Rust side of the project so any help to improve the Python bindings is very welcomed. For awareness, recently @johnnv1 have been helping a bit too here. Feel also free to join our discord to discuss more: https://discord.com/invite/HfnywwpBnD

@edgarriba
Copy link
Member

I believe this is done right ‘

@ngoldbaum
Copy link
Contributor Author

No this isn't done yet. I'm waiting on a PyO3 and rust-numpy 0.24 release before I can start working on kornia-rs.

@edgarriba edgarriba added enhancement New feature or request python labels Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

No branches or pull requests

2 participants