Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler and dialyzer warnings #15

Open
norton opened this issue Sep 25, 2012 · 0 comments
Open

compiler and dialyzer warnings #15

norton opened this issue Sep 25, 2012 · 0 comments

Comments

@norton
Copy link
Contributor

norton commented Sep 25, 2012

There are some compiler and dialyzer warnings that would be nice to fix. As time permits, I may also try to fix some of these.

compiler warnings:

src/hanoidb_fold_worker.erl:71: Warning: record state has field(s) without type     
src/hanoidb_level.erl:53: Warning: record state has field(s) without type information
src/basho_bench_driver_hanoidb.erl:27: Warning: record state has field(s) without type information
src/basho_bench_driver_hanoidb.erl:79: Warning: variable 'SyncInterval' exported from 'case' (

dialyzer Unknown functions:
hanoidb_utils:has_expired/1

dialyzer "nospec" warnings:
.... too many to list ....

I often find the following 2 passes of dialyzer to be quite helpful: first with no_spec and next with unmatched_returns.

diff --git a/Makefile b/Makefile
index 5071ea4..09ced93 100644
--- a/Makefile
+++ b/Makefile
@@ -37,6 +37,13 @@ plt: compile
 analyze: compile
        $(DIALYZER) --plt .hanoi.plt \
        -pa deps/plain_fsm/ebin \
+       -Wunmatched_returns \
+       ebin
+
+analyze-nospec: compile
+       $(DIALYZER) --plt .hanoi.plt \
+       -pa deps/plain_fsm/ebin \
+       --no_spec \
        ebin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant