Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After klog v2.0.0 release there are broken dependencies #138

Closed
biwwy0 opened this issue Apr 10, 2020 · 2 comments
Closed

After klog v2.0.0 release there are broken dependencies #138

biwwy0 opened this issue Apr 10, 2020 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@biwwy0
Copy link

biwwy0 commented Apr 10, 2020

/kind bug

What steps did you take and what happened:
after running dep ensure -update -v in a go project I get the following:

Solving failure: No versions of k8s.io/utils met constraints:
	master: Could not introduce k8s.io/utils@master, as it requires package k8s.io/klog/v2 from k8s.io/klog, but in version v2.0.0 that package is missing.
	godocs-readme: Could not introduce k8s.io/utils@godocs-readme due to multiple problematic subpackages:
	Subpackage k8s.io/utils/buffer is missing. (Package is required by k8s.io/[email protected].)	Subpackage k8s.io/utils/integer is missing. (Package is required by k8s.io/[email protected].)	Subpackage k8s.io/utils/trace is missing. (Package is required by k8s.io/[email protected].)

What did you expect to happen:
Having import "k8s.io/klog/v2" keep working as it is still used widely

Anything else you would like to add:
I see many projects still use k8s.io/klog/v2 endpoint in their source for klog v2. It would be nice to keep it for backward compatibility.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 10, 2020
@neolit123
Copy link
Member

/assign @dims

dep ensure -update -v in a go project I get the following:

i don't think the k8s project itself uses dep anymore, so not clear if it's considered supported.

as it requires package k8s.io/klog/v2 from k8s.io/klog, but in version v2.0.0 that package is missing.

we just switched k/utils to klog/v2:
kubernetes/utils#152

@biwwy0
Copy link
Author

biwwy0 commented Apr 10, 2020

It's not dep specific many projects, so if utils is good, then client-go is good too. Guess all is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants