Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename local_build option to build_type for greater flexibility #235

Closed
brienw opened this issue Apr 2, 2018 · 0 comments
Closed

Rename local_build option to build_type for greater flexibility #235

brienw opened this issue Apr 2, 2018 · 0 comments
Labels
Milestone

Comments

@brienw
Copy link
Contributor

brienw commented Apr 2, 2018

When I implemented local_build in #229 I think I had the short-term blinders on. After giving it a bit more thought I think this should be implemented as a more general build_type config option that we can use into the future. Right now i see at least three use-cases:

build_type: :remote - (DEFAULT) build using remote build host
build_type: :local - run build locally
build_type: :docker - run locally inside a docker container (to be implemented in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant