Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic classpath handling does not work #5

Closed
plexus opened this issue Jan 31, 2019 · 6 comments
Closed

Dynamic classpath handling does not work #5

plexus opened this issue Jan 31, 2019 · 6 comments
Assignees
Labels
closed:wontfix This will not be worked on

Comments

@plexus
Copy link
Member

plexus commented Jan 31, 2019

Kaocha adds any :test-paths to the classpath, so you don't have to, and so that only suites that are being run get added. However ClojureScript does not seem to pick up on this, so you need to add your test directories to the classpath yourself (e.g. in tools.deps with :paths or leiningen :test-paths).

Would be good to figure out what ClojureScript needs to make this work.

@plexus
Copy link
Member Author

plexus commented Jan 31, 2019

Related: #4

@urzae
Copy link

urzae commented May 6, 2019

/cc @urzds

@ghost
Copy link

ghost commented May 6, 2019

@plexus: We ran into this issue when taking our first steps at writing tests for our UI. Would it be possible to document this behaviour? Especially since this is not necessary for Clojure tests it took us a while to figure out what is wrong.

@plexus
Copy link
Member Author

plexus commented May 6, 2019

Sure, a PR for the README would be most welcome!

@alysbrooks alysbrooks moved this from Triage to 🙈Out of Scope in Lambda Island Open Source Sep 19, 2022
@plexus plexus added the documentation An issue or improvement related to documentation label Jan 25, 2023
@plexus plexus moved this from 🙈Out of Scope to Candidate in Lambda Island Open Source Jan 25, 2023
@plexus plexus changed the title Dynamic classpath handling does not work Documentation: Dynamic classpath handling does not work Jan 25, 2023
@fdserr fdserr self-assigned this Jan 30, 2023
@fdserr
Copy link

fdserr commented Jan 30, 2023

@plexus Isn't the readme already up to date on this issue?

[...]
## Known issues
- The :test-paths do not get automatically added to the classpath (at least not in a way that makes the sources visible to ClojureScript), so you need to also have any :test-paths in your project.clj/deps.edn/build.boot.
[...]

@plexus
Copy link
Member Author

plexus commented Feb 6, 2023

Right, makes sense that this was already documented. The original ticket was about figuring out if we can make it work on ClojureScript too. This could in theory still be investigated, but it's not something I want us to spend time on. Why? Because hacking the classpath like this is always hacky, and easily introduces new issues, or lead to suprising behavior. Let the tools that are designed to manage the classpath manage the classpath.

I think we have many other things to spend our time on that will have a greater positive impact for users.

So, until further notice I'm going to close this as "wontfix".

@plexus plexus closed this as completed Feb 6, 2023
@plexus plexus added closed:wontfix This will not be worked on and removed documentation An issue or improvement related to documentation labels Feb 6, 2023
@plexus plexus changed the title Documentation: Dynamic classpath handling does not work Dynamic classpath handling does not work Feb 6, 2023
@alysbrooks alysbrooks moved this from Candidate to 👀 In review in Lambda Island Open Source Feb 10, 2023
@alysbrooks alysbrooks moved this from 👀 In review to ❌ Won't fix in Lambda Island Open Source Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:wontfix This will not be worked on
Projects
Status: Won't fix
Development

No branches or pull requests

3 participants