Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Hnsw cost estimate #14

Closed
Ngalstyan4 opened this issue Jul 31, 2023 · 2 comments · Fixed by #103
Closed

Improve Hnsw cost estimate #14

Ngalstyan4 opened this issue Jul 31, 2023 · 2 comments · Fixed by #103
Labels
core Core Database

Comments

@Ngalstyan4
Copy link
Contributor

Properly implement postgres index cost estimation for postgres query planner

Resources

@Ngalstyan4 Ngalstyan4 changed the title Hnsw cost estimate Improve Hnsw cost estimate Aug 11, 2023
@yoloVoe
Copy link
Contributor

yoloVoe commented Aug 11, 2023

From Narek:

That issues requires quite an in depth understanding of the hnsw algorithm. You need to understand how the hyper-parameters of the algorithm (used in index creation via CREATE INDEX) affect the number of index pages read. So, make sure you read the hnsw paper and play with LanternDB before starting with this issue.

@Ngalstyan4 Ngalstyan4 added the core Core Database label Aug 14, 2023
@yoloVoe
Copy link
Contributor

yoloVoe commented Aug 28, 2023

Commits that make progress on this task.

There are further improvements we can do on top of the implementation above, but to gain confidence in improvements, we'd also need to add more test cases. Ideally, we'd be able to unit test the cost estimate function too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core Database
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants