[10.x] Illuminate\Filesystem\join_paths(): Argument #2 must be of type string, null given (#49467)

tylernathanreed · crynobone · web-flow · commit 1a84e34a2a91 · 2023-12-21T09:30:21.000-06:00
* + Added test that reproduces bug

* + Added fix that resolves bug

* Update src/Illuminate/Filesystem/functions.php

Co-authored-by: Mior Muhammad Zaki &lt;crynobone@gmail.com&gt;

* Update src/Illuminate/Filesystem/functions.php

Co-authored-by: Mior Muhammad Zaki &lt;crynobone@gmail.com&gt;

* ~ Don't explicitly test for null

---------

Co-authored-by: Mior Muhammad Zaki &lt;crynobone@gmail.com&gt;
diff --git a/src/Illuminate/Filesystem/functions.php b/src/Illuminate/Filesystem/functions.php
@@ -10,7 +10,7 @@
      * @param  string  ...$paths
      * @return string
      */
-    function join_paths($basePath, string ...$paths)
+    function join_paths($basePath, ...$paths)
     {
         foreach ($paths as $index => $path) {
             if (empty($path)) {

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* @param string ...$paths`
`11`	`11`	`* @return string`
`12`	`12`	`*/`
`13`		`- function join_paths($basePath, string ...$paths)`
	`13`	`+ function join_paths($basePath, ...$paths)`
`14`	`14`	`{`
`15`	`15`	`foreach ($paths as $index => $path) {`
`16`	`16`	`if (empty($path)) {`