[L5.5.13]: Resource route ordering

[joshbruce]

• Laravel Version: 5.5.13
• PHP Version: 7.1
• Database Driver & Version: MySQL

Description:

See also: #21258

Hmmmm...this seems to be an order of operations problem, which I might have noticed if route:list displayed them in the order they are interpreted. There might also be a better way to do what I'm trying to do.

1. I have a resource.
2. The index and show are publicly visible.
3. Everything else is behind auth.

Steps To Reproduce:

// Handle the public
Route::resource('your-resource', YourResourceController::class, [
        'only' => [
            'index',
            'show'
        ]
    ])
    ->middleware(['web']);

// Put everything else behind a wall
Route::resource('your-resource, YourResourceController::class, [
        'except' => [
            'index',
            'show'
        ]
    ])
    ->middleware(['web', 'auth']);

Create (/create) ends up with show (/{your-resource}). route:list shows the following.

your-resource
your-resource
your-resource/create
your-resource/{your-resource}

Thereby hiding the "defect", which is that the interpretation order is really:

your-resource
your-resource
your-resource/{your-resource}
your-resource/create

Due to the ordering of the route blocks. Switching them fixes the problem:

// Put everything else behind a wall
Route::resource('your-resource, YourResourceController::class, [
        'except' => [
            'index',
            'show'
        ]
    ])
    ->middleware(['web', 'auth']);

// Handle the public
Route::resource('your-resource', YourResourceController::class, [
        'only' => [
            'index',
            'show'
        ]
    ])
    ->middleware(['web']);

Maybe route:list can be made to list the routes in literal interpretation order?

Anyhow, just my UX brain have a hiccup.

[devcircus]

Yeah it seems like the list command just needs to be fixed to output the order correctly. If indeed the command should be responsible for that. It definitely makes sense for the "create" to be defined first.

[joshbruce]

No doubt. That is the question. If there's a more logical way to get feedback on the order the routes are interpreted...then it should definitely be there. From a UX perspective, route:list was the first place I went when the route was doing what was not expected. My literal thought was: "I bet the parameterized route is being hit first; therefore, it's going to show() instead of create(). I'll run route:list to verify."

When it wasn't in that order, I didn't knwo where else to look (you know what I'm saying?); so, started writing this and said, "I wonder..." then flipped them, which changed the nature of this ticket. :)

[Dylan-DPC-zz]

I wouldn't consider this is a bug. More of a proposal that can be made in laravel/internals

[themsaid]

You can use php artisan route:list --sort to get a sorted list.

[joshbruce]

@Dylan-DPC: Yeah. Wasn't considering a bug either. Is there a different format to use or something more explicit I can do in the future to differentiate? First time posting.

@themsaid: Thanks! Didn't know that was a thing already.

[Dylan-DPC-zz]

@joshbruce say the framework states that something works in an X way but you get the result in a Y way you can consider it a bug. Also if you are not sure you can ask in the forums or pop up on the slack channel (can DM me if you wish, no problems)