Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Thai language in search engine #2279

Closed
laurent22 opened this issue Jan 8, 2020 · 6 comments
Closed

Handle Thai language in search engine #2279

laurent22 opened this issue Jan 8, 2020 · 6 comments
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements mobile All mobile platforms

Comments

@laurent22
Copy link
Owner

The search engine uses FTS, which works only with alphabetical languages. Non-alphabetical ones, like Japanese, Korean, etc. are detected and handled in a special way - in this case we don't use FTS but do a simple plain text search (called "basic search" in Joplin).

We need to add the Thai language to that list of special cases. For that, have a look at SearchEngine::search to see how the switch between basic search and regular search is handled. Then add some code to detect the Thai language (in string-utils.js), and add it to the list of "basic search" languages.

@laurent22 laurent22 added enhancement Feature requests and code enhancements good first issue labels Jan 8, 2020
@Runo-saduwa
Copy link
Contributor

please can you assign this issue to me?, but permit me to ask questions if i am stuck because i am trying to give my first open source contribution. is this issue a Desktop issue because i am more comfortable with the desktop technologies

@laurent22 laurent22 added desktop All desktop platforms mobile All mobile platforms labels Jan 27, 2020
@laurent22
Copy link
Owner Author

Ok that's done @Runo-saduwa. This change is on code shared by desktop, mobile and cli but you only need to test on one platform, so just desktop is fine.

@Runo-saduwa
Copy link
Contributor

Runo-saduwa commented Jan 28, 2020

Please i dont understand what you mean by SearchEngine::search
where can i find this? @laurent22

@Runo-saduwa
Copy link
Contributor

@laurent22 , sorry for bothering you, but i'm a bit lost, i need some guide on how to implement this.

@laurent22
Copy link
Owner Author

@Runo-saduwa, I missed that it had already been implemented in this pull request so it's done already: #2387 If you'd like I can assign another one to you, just let me know which one.

@Runo-saduwa
Copy link
Contributor

Runo-saduwa commented Jan 29, 2020

Ok, Please assign this to me #2383 , thanks

@lock lock bot locked and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements mobile All mobile platforms
Projects
None yet
Development

No branches or pull requests

2 participants