Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rcases use the induction/cases framework #3901

Open
kmill opened this issue Apr 13, 2024 · 1 comment
Open

Make rcases use the induction/cases framework #3901

kmill opened this issue Apr 13, 2024 · 1 comment
Labels
enhancement New feature or request P-medium We may work on this issue if we find the time

Comments

@kmill
Copy link
Collaborator

kmill commented Apr 13, 2024

Currently rcases uses Lean.MVarId.cases, but the cases tactic uses its own system of applying casesOn.

The rcases tactic should use the same system as cases.

Note that #3747 introduced a hack into Lean.MVarId.cases via the useNatCasesAuxOn argument for the "beautiful Nat induction" project. This should be removed, since this has a general solution via @[induction_eliminator] and @[cases_eliminator] in induction/cases. (The Lean.MVarId.cases is a low-level function that should not use user-defined eliminators.)

@kmill kmill added the enhancement New feature or request label Apr 13, 2024
@nomeata
Copy link
Collaborator

nomeata commented Apr 13, 2024

The Lean.MVarId.cases is a low-level function that should not use user-defined eliminators.)

Maybe worth renaming. It's confusing if Lean.MVarId.foo and tactic foo are mostly unrelated.

@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P-medium We may work on this issue if we find the time
Projects
None yet
Development

No branches or pull requests

3 participants