Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce copying for Addrs and AllAddrs in BasicHost #3198

Closed
sukunrt opened this issue Feb 17, 2025 · 0 comments · Fixed by #3200
Closed

reduce copying for Addrs and AllAddrs in BasicHost #3198

sukunrt opened this issue Feb 17, 2025 · 0 comments · Fixed by #3200

Comments

@sukunrt
Copy link
Member

sukunrt commented Feb 17, 2025 

          Let's change `.addCertHashes` to always return a copy, and remove this.

Otherwise we end up making two copies.

Originally posted by @MarcoPolo in #3071 (comment)
@MarcoPolo MarcoPolo added help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/beginner Can be confidently tackled by newcomers labels Feb 17, 2025
@sukunrt sukunrt removed help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/beginner Can be confidently tackled by newcomers labels Feb 18, 2025
@sukunrt sukunrt mentioned this issue Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

basichost: add certhashes to addrs in place libp2p/go-libp2p
2 participants
@MarcoPolo @sukunrt