-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clock doe not rotate to landscape mode (cant read number of opponent upside down) #1492
Comments
no, you cannot focus to such a small number during a game. |
The app currently allows landscape orientation only on devices with a larger screen size, such as tablets. On phones with smaller screens, it explicitly forces the orientation to portrait using the following snippet: Line 148 in daa8fc2
As seen in the image below, landscape mode already functions like this. I'm unsure whether it would be beneficial to specifically enable both landscape and portrait orientations just for the clock screen. Was your request exactly about this behavior? If I've misunderstood something, please correct me. |
yes, thats what it should look like also on phones. |
I like what you did and agree with the logic. Any reason you closed the pr unmerged? |
Yeah, I liked it too. It would definitely be easier to check the opponent’s time in portrait mode. But I closed it since I didn’t think it was directly related to this issue. If someone opens a separate issue for this, I think it’d be great, and we could reopen it. |
|
What is the problem?
clock should switch to landsacpe mode so both players can read both numbers
It is a FIDE requirement that both players have to be able to read both times
Steps to reproduce the bug
open clock.
wonder why.
App version
0.10.18
Device Info
Samsung S10
Additional information
No response
The text was updated successfully, but these errors were encountered: