Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock doe not rotate to landscape mode (cant read number of opponent upside down) #1492

Open
malo1972 opened this issue Feb 25, 2025 · 7 comments · May be fixed by #1531
Open

Clock doe not rotate to landscape mode (cant read number of opponent upside down) #1492

malo1972 opened this issue Feb 25, 2025 · 7 comments · May be fixed by #1531
Labels
bug Something isn't working

Comments

@malo1972
Copy link

What is the problem?

clock should switch to landsacpe mode so both players can read both numbers
It is a FIDE requirement that both players have to be able to read both times

Steps to reproduce the bug

open clock.
wonder why.

App version

0.10.18

Device Info

Samsung S10

Additional information

No response

@malo1972 malo1972 added the bug Something isn't working label Feb 25, 2025
@okmsbun
Copy link
Contributor

okmsbun commented Mar 6, 2025

I've made some code changes to address this issue. Would this be a suitable solution? Does this approach make sense, or is there a better way to handle it?

Image

@malo1972
Copy link
Author

malo1972 commented Mar 7, 2025

no, you cannot focus to such a small number during a game.
Why not turn both numbers 90 degrees so they have the same orientation (landscape)
This may be optional for players who like it as it is.

@okmsbun
Copy link
Contributor

okmsbun commented Mar 7, 2025

The app currently allows landscape orientation only on devices with a larger screen size, such as tablets. On phones with smaller screens, it explicitly forces the orientation to portrait using the following snippet:

await SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]);

As seen in the image below, landscape mode already functions like this. I'm unsure whether it would be beneficial to specifically enable both landscape and portrait orientations just for the clock screen. Was your request exactly about this behavior? If I've misunderstood something, please correct me.

Image

@malo1972
Copy link
Author

malo1972 commented Mar 7, 2025

yes, thats what it should look like also on phones.
The current orientation does not make sense to me.
I know it is not a FIDE-clock, but from FIDE rules:
"The clock should be placed in such a way that it is clearly visible to both players and the arbiter"
...without turning its head upside down :-)
they can do it: https://play.google.com/store/apps/details?id=com.chess.clock&pcampaignid=web_share
I urgently want to uninstall it. Thats why...

@ijm8710
Copy link

ijm8710 commented Mar 7, 2025

I like what you did and agree with the logic. Any reason you closed the pr unmerged?

@okmsbun
Copy link
Contributor

okmsbun commented Mar 7, 2025

Yeah, I liked it too. It would definitely be easier to check the opponent’s time in portrait mode. But I closed it since I didn’t think it was directly related to this issue. If someone opens a separate issue for this, I think it’d be great, and we could reopen it.

@ijm8710
Copy link

ijm8710 commented Mar 7, 2025

Yeah, I liked it too. It would definitely be easier to check the opponent’s time in portrait mode. But I closed it since I didn’t think it was directly related to this issue. If someone opens a separate issue for this, I think it’d be great, and we could reopen it.

#1529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants