-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private class constructors should be ignored #738
Labels
Comments
This was referenced Jan 13, 2023
This was referenced Aug 9, 2023
@SethTisue Could you take a look at my approach in #778 please? |
The issue is fixed by #778. |
was this released? I couldn't find if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MiMa flags changes in private constructor signatures:
Here, MiMa fails with a message like:
However, the constructor is private, so the change is safe.
What happens is that although the constructor can’t be called from Scala code, it is effectively public in the bytecode (just like
private[x]
members).MiMa should detect this pattern and ignore the changes to private class constructors.
Related discussions:
scala/bug#12711
scala/scala3#16651
scala/docs.scala-lang#2662
https://contributors.scala-lang.org/t/private-primary-constructor-vs-mima/6050
PR ignoring
private[x]
members: #583The text was updated successfully, but these errors were encountered: