Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: sub-sat/vbyte precision for sendcoins #9569

Open
starius opened this issue Mar 1, 2025 · 0 comments
Open

[feature]: sub-sat/vbyte precision for sendcoins #9569

starius opened this issue Mar 1, 2025 · 0 comments
Labels
enhancement Improvements to existing features / behaviour

Comments

@starius
Copy link
Collaborator

starius commented Mar 1, 2025

Is your feature request related to a problem? Please describe.

I would like to use lncli sendcoins to send a transaction with a fee rate of 1.2 sat/vbyte, as this is currently an optimal rate. However, the current implementation only supports integer values for the fee rate, which means I can only choose between 1 sat/vbyte (too low, causing long confirmation times) or 2 sat/vbyte (overpaying by 66%).

Describe the solution you'd like

Ideally, the following command should work as expected:

lncli sendcoins --sat_per_vbyte 1.2

Currently, the sat_per_vbyte option in SendCoinsRequest is defined as an integer. To address this, I propose adding a new field, sat_per_kw, to SendCoinsRequest.

  • Only one of sat_per_vbyte or sat_per_kw should be allowed in a request.
  • Modify lncli to accept fractional fee rates, convert them to sat/kw, and send them as sat_per_kw.
  • We can deprecate sat_per_vbyte.

This change would allow users to specify more precise fee rates without unnecessary overpayment.

@starius starius added the enhancement Improvements to existing features / behaviour label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour
Projects
None yet
Development

No branches or pull requests

1 participant