New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: fn/v2: test flake in TestPropForEachConcOutperformsMapWhenExpensive #9578

Open

ellemouton opened this issue Mar 5, 2025 · 0 comments

Labels

Collaborator

ellemouton commented Mar 5, 2025

--- FAIL: TestPropForEachConcOutperformsMapWhenExpensive (0.46s)
    slice_test.go:341: #66: failed on input -485591796543117135, []int{2699404122135167197, -104612[95](https://github.com/lightningnetwork/lnd/actions/runs/13669597198/job/38217230568?pr=9577#step:9:96)91028623399}
FAIL
FAIL	github.com/lightningnetwork/lnd/fn/v2	1.700s
FAIL

// TestPropForEachConcOutperformsMapWhenExpensive ensures the property that
// ForEachConc will beat Map in a race in circumstances where the computation in
// the argument closure is expensive.

So either the test is flaky, or the above property does not actually hold true.

Appeared in this build

The text was updated successfully, but these errors were encountered:

ellemouton added bug needs triage test flake and removed needs triage labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment