Skip to content
This repository was archived by the owner on Jul 20, 2024. It is now read-only.

xed: Default gtksourceview style doesn't work well with dark themes #60

Closed
Jeremy7701 opened this issue Jul 2, 2024 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Jeremy7701
Copy link

/usr/share/nemo/actions/sample.nemo_action is unreadable, at least in dark mode since most of the text is pale blue on black.

I suggest all colour coding is removed.

Part example:-
Screenshot from 2024-07-02 20-24-20

@mtwebster
Copy link
Member

mtwebster commented Jul 2, 2024

This Xed's default theme color for comments in many (most?) file formats. It's not specific to nemo action files. Select a different theme in Xed's preferences as a workaround for now. I'm not sure we can modify these themes, depending on what package provides them.

@Jeremy7701
Copy link
Author

Jeremy7701 commented Jul 2, 2024

There is a solution : Xed allows you to choose a theme from its Edit -> preferences.
The 'Kate' theme looks quite good on a dark screen.
Sorry if I misinterpreted your use of the word "theme" !
Screenshot from 2024-07-02 21-20-47

@clefebvre
Copy link
Member

I wonder if we could provide a light gtksourceview theme, and default to it. The one we default to right now, isn't always light, it's made for light, but doesn't hardcode the background color..

@clefebvre clefebvre changed the title Nemo - unreadability of sample nemo actions file in dark mode xed: Default gtksourceview doesn't work well with dark themes Jul 4, 2024
@clefebvre clefebvre changed the title xed: Default gtksourceview doesn't work well with dark themes xed: Default gtksourceview style doesn't work well with dark themes Jul 4, 2024
@clefebvre clefebvre added the bug Something isn't working label Jul 4, 2024
@clefebvre
Copy link
Member

For the line numbers there's a regression between 21.x and 22:

image

They went from a relative rgba shade to a hardcoded color.

@clefebvre
Copy link
Member

@clefebvre
Copy link
Member

Reverting this and switching the comments to grey gives a good result in both light and dark scenarios.

@clefebvre
Copy link
Member

clefebvre commented Jul 4, 2024

Fixed in xed 3.6.4 (with new default "Xed" style chosen).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants