Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DirectX] Propagate shader flags mask for entry functions #112949

Closed
Tracked by #57
bharadwajy opened this issue Oct 18, 2024 · 0 comments · Fixed by #118306
Closed
Tracked by #57

[DirectX] Propagate shader flags mask for entry functions #112949

bharadwajy opened this issue Oct 18, 2024 · 0 comments · Fixed by #118306
Assignees

Comments

@bharadwajy
Copy link
Contributor

bharadwajy commented Oct 18, 2024

Once the change that implements per-function shader flag mask collection is merged, implement the mechanism to propagate compute shader flags mask for entry functions based on the shader flags mask of functions called by the entry function.

Implement any additional validation necessary involving module flags collected.

AC:

  • Add tests with entry functions that call other non-entry functions to verify correctness of the emitted shader flag mask in metadata and in the generated DXIL Container binary.
  • Ensure correctness of added tests by compiling for library and non-library targets.
@bharadwajy bharadwajy changed the title Construct and validate the shader flags mask for entry functions [DirectX] Construct and validate the shader flags mask for entry functions Oct 18, 2024
@bharadwajy bharadwajy self-assigned this Oct 21, 2024
@bharadwajy bharadwajy moved this to Designing in HLSL Support Oct 21, 2024
@damyanp damyanp moved this from Designing to Planning in HLSL Support Oct 22, 2024
@davidcook-msft davidcook-msft moved this from Planning to Active in HLSL Support Oct 22, 2024
@bharadwajy bharadwajy changed the title [DirectX] Construct and validate the shader flags mask for entry functions [DirectX] Propagate shader flags mask for entry functions Nov 4, 2024
@bharadwajy bharadwajy moved this from Active to Needs Review in HLSL Support Dec 2, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Closed in HLSL Support Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants