Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the EvaluateAttributeAtSample HLSL Function #99109

Open
9 tasks
Tracked by #99235
farzonl opened this issue Jul 16, 2024 · 1 comment
Open
9 tasks
Tracked by #99235

Implement the EvaluateAttributeAtSample HLSL Function #99109

farzonl opened this issue Jul 16, 2024 · 1 comment
Labels
backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.

Comments

@farzonl
Copy link
Member

farzonl commented Jul 16, 2024

  • Implement EvaluateAttributeAtSample clang builtin,
  • Link EvaluateAttributeAtSample clang builtin with hlsl_intrinsics.h
  • Add sema checks for EvaluateAttributeAtSample to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp
  • Add codegen for EvaluateAttributeAtSample to EmitHLSLBuiltinExpr in CGBuiltin.cpp
  • Add codegen tests to clang/test/CodeGenHLSL/builtins/EvaluateAttributeAtSample.hlsl
  • Add sema tests to clang/test/SemaHLSL/BuiltIns/EvaluateAttributeAtSample-errors.hlsl
  • Create the int_dx_EvaluateAttributeAtSample intrinsic in IntrinsicsDirectX.td
  • Create the DXILOpMapping of int_dx_EvaluateAttributeAtSample to 88 in DXIL.td
  • Create the EvaluateAttributeAtSample.ll and EvaluateAttributeAtSample_errors.ll tests in llvm/test/CodeGen/DirectX/

DirectX

DXIL Opcode DXIL OpName Shader Model Shader Stages
88 EvalSampleIndex 6.0 ('pixel',)

SPIR-V

There is no support for EvaluateAttributeAtSample when targeting SPIR-V.

Test Case(s)

Example 1

//dxc EvaluateAttributeAtSample_test.hlsl -T lib_6_8 -enable-16bit-types -O0

[numthreads(1, 1, 1)]
[shader("pixel")]
float4 fn(float4 p1 : COLOR ) : SV_Target {
	uint p2;
	return EvaluateAttributeAtSample(p1, p2);
}

HLSL:

Evaluates at the indexed sample location.

Syntax

numeric EvaluateAttributeAtSample(
  in attrib numeric value,
  in uint sampleindex
);

Parameters

value [in]

Type: attrib numeric

The input value.

sampleindex [in]

Type: uint

The sample location.

Remarks

Interpolation mode can be linear or linear_no_perspective on the variable. Use of centroid or sample is ignored. Attributes with constant interpolation are also allowed, in which case the sample index is ignored.

Minimum Shader Model

This function is supported in the following shader models.

Shader Model Supported
Shader Model 5 and higher shader models yes

 

This function is supported in the following types of shaders:

Vertex Hull Domain Geometry Pixel Compute
x

 

See also

Intrinsic Functions

Shader Model 5

@farzonl farzonl added backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues. labels Jul 16, 2024
@damyanp damyanp moved this to Ready in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Ready to Planning in HLSL Support Oct 30, 2024
@davidcook-msft davidcook-msft moved this from Planning to Designing in HLSL Support Nov 12, 2024
@davidcook-msft
Copy link

This feature is being discussed in hlsl-specs here: microsoft/hlsl-specs#181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.
Projects
Status: Designing
Development

No branches or pull requests

2 participants