Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the ProcessTriTessFactorsMax HLSL Function #99149

Open
9 tasks
Tracked by #99235
farzonl opened this issue Jul 16, 2024 · 1 comment
Open
9 tasks
Tracked by #99235

Implement the ProcessTriTessFactorsMax HLSL Function #99149

farzonl opened this issue Jul 16, 2024 · 1 comment
Labels
backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.

Comments

@farzonl
Copy link
Member

farzonl commented Jul 16, 2024

  • Implement ProcessTriTessFactorsMax clang builtin,
  • Link ProcessTriTessFactorsMax clang builtin with hlsl_intrinsics.h
  • Add sema checks for ProcessTriTessFactorsMax to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp
  • Add codegen for ProcessTriTessFactorsMax to EmitHLSLBuiltinExpr in CGBuiltin.cpp
  • Add codegen tests to clang/test/CodeGenHLSL/builtins/ProcessTriTessFactorsMax.hlsl
  • Add sema tests to clang/test/SemaHLSL/BuiltIns/ProcessTriTessFactorsMax-errors.hlsl
  • Create the int_dx_ProcessTriTessFactorsMax intrinsic in IntrinsicsDirectX.td
  • Create the DXILOpMapping of int_dx_ProcessTriTessFactorsMax to 106 in DXIL.td
  • Create the ProcessTriTessFactorsMax.ll and ProcessTriTessFactorsMax_errors.ll tests in llvm/test/CodeGen/DirectX/

DirectX

DXIL Opcode DXIL OpName Shader Model Shader Stages
106 StorePatchConstant 6.0 ('hull',)

SPIR-V

There is no support for ProcessTriTessFactorsMax when targeting SPIR-V.

Test Case(s)

Example 1

//dxc ProcessTriTessFactorsMax_test.hlsl -T hs_6_8 -enable-16bit-types -O0

struct HSPerPatchData
{
	float edges[ 3 ] : SV_TessFactor;
	float inside : SV_InsideTessFactor;
};
struct PSSceneIn {
	float4 pos : SV_Position;
	float2 tex : TEXCOORD0;
	float3 norm : NORMAL;
};
struct HSPerVertexData {
	PSSceneIn v;
};

export HSPerPatchData fn( const InputPatch< PSSceneIn, 3 > points ) {
	HSPerPatchData d;
	float4 edgeFactor;
	float2 insideFactor;float3 p1;
float p2;
float3 p3;
float p4;
float p5;
ProcessTriTessFactorsMax(p1, p2, p3, p4, p5);

	d.edges[0]=edgeFactor.x;
	d.edges[1]=edgeFactor.y;
	d.edges[2]=edgeFactor.z + edgeFactor.w;
	d.inside = insideFactor.x + insideFactor.y;
	return d;
}

[domain("tri")]
[outputtopology("triangle_cw")]
[patchconstantfunc("fn")]
[outputcontrolpoints(3)]
[partitioning("pow2")]
HSPerVertexData main( const uint id : SV_OutputControlPointID,const InputPatch< PSSceneIn, 3 > points ) {

	HSPerVertexData v;
	v.v = points[ id ];
	return v;
}

HLSL:

Generates the corrected tessellation factors for a tri patch.

Syntax

void ProcessTriTessFactorsMax(
  in  float3 RawEdgeFactors,
  in  float InsideScale,
  out float3 RoundedEdgeTessFactors,
  out float RoundedInsideTessFactor,
  out float UnroundedInsideTessFactor
);

Parameters

RawEdgeFactors [in]

Type: float3

The edge tessellation factors, passed into the tessellator stage.

InsideScale [in]

Type: float

The scale factor applied to the UV tessellation factors computed by the tessellation stage. The allowable range for InsideScale is 0.0 to 1.0.

RoundedEdgeTessFactors [out]

Type: float3

The rounded edge-tessellation factors calculated by the tessellator stage.

RoundedInsideTessFactor [out]

Type: float

The tessellation factors calculated by the tessellator stage, and rounded.

UnroundedInsideTessFactor [out]

Type: float

The original, unrounded, UV tessellation factors computed by the tessellation stage.

Return value

This function does not return a value.

Remarks

Generates the corrected tessellation factors for a tri patch, computing the inside tessellation factor as the maximum of the edge tessellation factors, which is then scaled by InsideScale. The result is then rounded based on the partitioning mode, but the unrounded results are available using the UnroundedInsideTessFactor parameter.

Minimum Shader Model

This function is supported in the following shader models.

Shader Model Supported
Shader Model 5 and higher shader models yes

 

This function is supported in the following types of shaders:

Vertex Hull Domain Geometry Pixel Compute
x

 

See also

Intrinsic Functions

Shader Model 5

@farzonl farzonl added backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues. labels Jul 16, 2024
@damyanp damyanp moved this to Ready in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Ready to Planning in HLSL Support Oct 30, 2024
@pow2clk
Copy link
Contributor

pow2clk commented Nov 19, 2024

Tessellation-specific helper functions. Implementable in the header.

@pow2clk pow2clk moved this from Planning to Designing in HLSL Support Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.
Projects
Status: Designing
Development

No branches or pull requests

2 participants