Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the WaveMultiPrefixBitOr HLSL Function #99209

Open
12 tasks
Tracked by #99235
farzonl opened this issue Jul 16, 2024 · 0 comments
Open
12 tasks
Tracked by #99235

Implement the WaveMultiPrefixBitOr HLSL Function #99209

farzonl opened this issue Jul 16, 2024 · 0 comments
Labels
backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.

Comments

@farzonl
Copy link
Member

farzonl commented Jul 16, 2024

  • Implement WaveMultiPrefixBitOr clang builtin,
  • Link WaveMultiPrefixBitOr clang builtin with hlsl_intrinsics.h
  • Add sema checks for WaveMultiPrefixBitOr to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp
  • Add codegen for WaveMultiPrefixBitOr to EmitHLSLBuiltinExpr in CGBuiltin.cpp
  • Add codegen tests to clang/test/CodeGenHLSL/builtins/WaveMultiPrefixBitOr.hlsl
  • Add sema tests to clang/test/SemaHLSL/BuiltIns/WaveMultiPrefixBitOr-errors.hlsl
  • Create the int_dx_WaveMultiPrefixBitOr intrinsic in IntrinsicsDirectX.td
  • Create the DXILOpMapping of int_dx_WaveMultiPrefixBitOr to 166 in DXIL.td
  • Create the WaveMultiPrefixBitOr.ll and WaveMultiPrefixBitOr_errors.ll tests in llvm/test/CodeGen/DirectX/
  • Create the int_spv_WaveMultiPrefixBitOr intrinsic in IntrinsicsSPIRV.td
  • In SPIRVInstructionSelector.cpp create the WaveMultiPrefixBitOr lowering and map it to int_spv_WaveMultiPrefixBitOr in SPIRVInstructionSelector::selectIntrinsic.
  • Create SPIR-V backend test case in llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WaveMultiPrefixBitOr.ll

DirectX

DXIL Opcode DXIL OpName Shader Model Shader Stages
166 WaveMultiPrefixOp 6.5 ('library', 'compute', 'amplification', 'mesh', 'pixel', 'vertex', 'hull', 'domain', 'geometry', 'raygeneration', 'intersection', 'anyhit', 'closesthit', 'miss', 'callable', 'node')

SPIR-V

OpGroupNonUniformBitwiseOr:

Description:

A bitwise or group operation of all Value operands
contributed by active invocations in the
group.

Result Type must be a scalar or vector of integer
type
.

Execution is a Scope that identifies the group of
invocations affected by this command. It must be Subgroup.

The identity I for Operation is 0. If Operation is
ClusteredReduce, ClusterSize must be present.

The type of Value must be the same as Result Type.

ClusterSize is the size of cluster to use. ClusterSize must be a
scalar of integer type, whose Signedness operand is 0.
ClusterSize must come from a constant
instruction
. Behavior is undefined unless
ClusterSize is at least 1 and a power of 2. If ClusterSize is
greater than the size of the group, executing this instruction
results in undefined behavior.

Capability:
GroupNonUniformArithmetic, GroupNonUniformClustered,
GroupNonUniformPartitionedNV

Missing before version 1.3.

Word Count Opcode Results Operands

6 + variable

360

<id>
Result Type

Result <id>

Scope <id>
Execution

Group Operation
Operation

<id>
Value

Optional
<id>
ClusterSize

Test Case(s)

Example 1

//dxc WaveMultiPrefixBitOr_test.hlsl -T lib_6_8 -enable-16bit-types -O0

export int4 fn(int4 p1, uint4 p2) {
    return WaveMultiPrefixBitOr(p1, p2);
}

HLSL:

Syntax

any_int<> WaveMultiPrefixBitOr(any_int<> value, uint<4> mask);

Type Description

Name Template Type Component Type Size
ret scalar, vector, or matrix int, int16_t, int64_t, uint, uint16_t, or uint64_t any
value scalar, vector, or matrix int, int16_t, int64_t, uint, uint16_t, or uint64_t any
mask vector uint 4

Minimum Shader Model

This function is supported in the following shader models.

Shader Model Supported
Shader Model 6.5 and higher shader models yes

Shader Stages

See also

@farzonl farzonl added backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues. labels Jul 16, 2024
@damyanp damyanp moved this to Ready in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Ready to Planning in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Planning to Ready in HLSL Support Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.
Projects
Status: Ready
Development

No branches or pull requests

1 participant