Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow additional properties for schema in values.schema.json #3815

Open
fengelniederhammer opened this issue Mar 10, 2025 · 1 comment
Open

Comments

@fengelniederhammer
Copy link
Contributor

fengelniederhammer commented Mar 10, 2025

... that particular object (the schema) doesn't have additionalProperties: false set. Maybe @fengelniederhammer you could add it in? Sorry for that!

Originally posted by @fhennig in #3814 (comment)

It is not immediately possible as there are errors when adding "additionalProperties": false to schema -> I'll leave it to a separate issue.

$ helm lint .
==> Linting .
[ERROR] values.yaml: - defaultOrganismConfig.schema: Additional property extraInputFields is not allowed
- defaultOrganisms.west-nile.schema: Additional property metadataAdd is not allowed
- defaultOrganisms.west-nile.schema: Additional property extraInputFields is not allowed
- defaultOrganisms.cchf.schema: Additional property metadataAdd is not allowed
- defaultOrganisms.cchf.schema: Additional property extraInputFields is not allowed
- defaultOrganisms.cchf.schema: Additional property nucleotideSequences is not allowed
- defaultOrganisms.dummy-organism-without-seqs.schema: Additional property nucleotideSequences is not allowed
- defaultOrganisms.ebola-sudan.schema: Additional property extraInputFields is not allowed

[ERROR] templates/: values don't meet the specifications of the schema(s) in the following chart(s):
loculus:
- defaultOrganismConfig.schema: Additional property extraInputFields is not allowed
- defaultOrganisms.dummy-organism-without-seqs.schema: Additional property nucleotideSequences is not allowed
- defaultOrganisms.ebola-sudan.schema: Additional property extraInputFields is not allowed
- defaultOrganisms.west-nile.schema: Additional property extraInputFields is not allowed
- defaultOrganisms.west-nile.schema: Additional property metadataAdd is not allowed
- defaultOrganisms.cchf.schema: Additional property metadataAdd is not allowed
- defaultOrganisms.cchf.schema: Additional property nucleotideSequences is not allowed
- defaultOrganisms.cchf.schema: Additional property extraInputFields is not allowed


Error: 1 chart(s) linted, 1 chart(s) failed
@fhennig
Copy link
Contributor

fhennig commented Mar 10, 2025

Thanks for creating this issue, I'll put it on my list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants