Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONB instead of JSON #17

Closed
mickdelaney opened this issue Apr 26, 2016 · 6 comments
Closed

JSONB instead of JSON #17

mickdelaney opened this issue Apr 26, 2016 · 6 comments

Comments

@mickdelaney
Copy link

Hi,
Would it be possible/make sense to allow JSONB instead of JSON as the data column type ?
Currently I end up changing the data column to JSONB after its imported which takes time.

Thanks for the a great project btw.

Regards

@lukasmartinelli
Copy link
Owner

Hi,
Would it be possible/make sense to allow JSONB instead of JSON as the data column type ?
Currently I end up changing the data column to JSONB after its imported which takes time.

Thanks for the a great project btw.

Regards

Yes initially wanted to use JSONB but was only supported after Postgres 9.4.
Will try to provide flag or separate jsonb import command.

@buildbreakdo
Copy link

Can you close this? Quickly scanned this the other day and somehow thought it hadn't been implemented yet and it has. Thanks so much for this lib, has significantly improved my work flow! Awesome work! 👍

@buildbreakdo
Copy link

buildbreakdo commented Sep 18, 2016

Used the Linux wget link: wget -O pgfutter https://github.com/lukasmartinelli/pgfutter/releases/download/v1.0/pgfutter_linux_amd64

And realised this version does not have jsonb support. Should download links be updated to latest? Looks like you can here: https://help.github.com/articles/linking-to-releases/ with

Right click on Latest Release and copy the URL to share it. The suffix of this URL is always /releases/latest.

Seems as though that is only if a release has been tagged and then only links to the html version and not package.. just trying to get the latest version with all the goodies. :) Downloading go to use Go get.. which looks like links directly to the repo. Zero experience with Go, should be interesting. Cheers

@buildbreakdo
Copy link

Using go get worked to get the latest. Strange that both are listed as version 1.0 when they have different feature sets. Looked at semantic versioning that is popular with the node crowd? http://semver.org/

@lukasmartinelli
Copy link
Owner

And realised this version does not have jsonb support. Should download links be updated to latest? Looks like you can here: https://help.github.com/articles/linking-to-releases/ with

The version just was not up to par with master (I am a bit slow with releases).
Did one today for the JSONB support https://github.com/lukasmartinelli/pgfutter/releases/tag/v1.1

I think I am doing something similar to semver (any suggestions?). I had v0.* but then switched to v1.* when I thought the API is stable and now doing minor upgrades (v1.1..v1.2)

@buildbreakdo
Copy link

Would recommend following semver as close as possible, it is well understood and documented. The three biggest Go projects that I am aware of use semver as well CoreOS, Kubernetes, and Docker.

Yeah the bump to 1.0.0 makes sense when you have a stable API. Think their summary is on point:

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.

Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants