Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build checks for go fmt and go mod tidy #268

Closed
markfuller opened this issue May 10, 2019 · 0 comments · Fixed by #263
Closed

Add build checks for go fmt and go mod tidy #268

markfuller opened this issue May 10, 2019 · 0 comments · Fixed by #263
Assignees

Comments

@markfuller
Copy link
Contributor

markfuller commented May 10, 2019

Is your feature request related to a problem? Please describe.
Add some build checks to ensure that go mod tidy and go fmt ./... would not make any changes.

Describe the solution you'd like
In travis:

  • If go fmt ./... changes any files, fail the build
  • If go mod tidy changes go.sum, fail the build

Describe alternatives you've considered
N/A

Additional context
This will require an upgrade to go 1.12 due to golang/go#27868 (contributors could work locally without it but any PRs containing modifications to go.sum are likely to be rejected)

Travis (go stable) is already running 1.12.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant