Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag 3.0.1 doesn't respect semantic versionning (introduce breaking change) #53

Closed
jdecool opened this issue Mar 2, 2022 · 2 comments
Closed

Tag 3.0.1 doesn't respect semantic versionning (introduce breaking change) #53

jdecool opened this issue Mar 2, 2022 · 2 comments

Comments

@jdecool
Copy link
Contributor

jdecool commented Mar 2, 2022

The latest version (3.0.1) doesn't respect semantic versionning and introduce a breaking change on a patch version.

PR #52 has removed the src/MailjetMailServiceProvider.php file which is, according to the documentation, required in the providers array (cf.

laravel-mailjet/README.md

Line 28 in 1878b0f

Mailjet\LaravelMailjet\MailjetMailServiceProvider::class,
)

image
@Baser-T
Copy link

Baser-T commented Mar 3, 2022

Is it possible that this is the reason why I'd get a 500 error on sending a verificationmail? as of the update after commenting the MailjetMailServiceProvider out I seem to get 500 error when sending mails towards mailjet.

@Pavlico
Copy link
Collaborator

Pavlico commented Mar 16, 2022

#54 merged

@Pavlico Pavlico closed this as completed Mar 16, 2022
@FrancescJR FrancescJR mentioned this issue Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdecool @Pavlico @Baser-T