Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$this->app->share deprecated in 5.4 #82

Open
whoacowboy opened this issue Feb 12, 2017 · 1 comment
Open

$this->app->share deprecated in 5.4 #82

whoacowboy opened this issue Feb 12, 2017 · 1 comment

Comments

@whoacowboy
Copy link

Couldn't figure out the pull request.

https://github.com/maknz/slack/blob/1.7.0/src/SlackServiceProviderLaravel5.php#L27

Change

$this->app['maknz.slack'] = $this->app->share(function($app)

to

$this->app->singleton('maknz.slack', function($app)
@AlexDanault
Copy link

@maknz said on twitter that he doesn't have time to maintain this package anymore and will soon post a deprecation notice.

Link: https://twitter.com/maknz/status/833866298232754177

@PunchRockgroin PunchRockgroin mentioned this issue Feb 24, 2017
Merged
@rikeda001 rikeda001 mentioned this issue Mar 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexDanault @whoacowboy