Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older version of recharts used, gives peer dependency warning for react 19 #7356

Closed
1 of 2 tasks
ShadowWolf308 opened this issue Jan 14, 2025 · 3 comments
Closed
1 of 2 tasks
Labels
Duplicate A duplicate of other issue

Comments

@ShadowWolf308
Copy link

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.16.0

What package has an issue?

@mantine/charts

What framework do you use?

Vite

In which browsers you can reproduce the issue?

Not applicable – issue is not related to the browser

Describe the bug

The package contains a peer dependency for recharts ^2.13.3
This version is not explicitly compatible with react 19 and gives a warning when you install the package
image

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

Update the dependency to recharts 2.15.x as this has react 19 marked as a compatible peer dependency

Self-service

  • I would be willing to implement a fix for this issue
@rtivital
Copy link
Member

I do not get the issue. ^2.13.3 means that any 2.x version above 2.13.3 can be used, for example 2.15.0 can be installed in your application. Please provide a more detailed explanation.

@ShadowWolf308
Copy link
Author

It has somehow fixed itself, i think because i updated the packages it found that version in the node_modules folder and then reused that old version even when i specified that it should ignore the lockfile and such.

however i did need to put "react-is": "19.0.0" in my overrides in my package.json file as described here by recharts, without that in, for example, the area chart only the dots are visible
image

@rtivital
Copy link
Member

Reacharts issue is described here #7220
It cannot be fixed on Mantine side.

@rtivital rtivital added the Duplicate A duplicate of other issue label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate A duplicate of other issue
Projects
None yet
Development

No branches or pull requests

2 participants