Bug 1937663 [wpt PR 49719] - Fix a bug in test_driver.bless(), a=testonly

Automatic update from web-platform-tests
Fix a bug in test_driver.bless() (#49719)

This code was previously doing this:

  let wait_click = new Promise(resolve => {
    button.addEventListener("click", resolve));
  };
  return test_driver.click(button)
    .then(wait_click)
    .then(...

but the argument to `.then(wait_click)` isn't a function, it's the
promise to return. Therefore .then() creates an already-resolved
promise containing `wait_click` as its resolved value. Which the next
`.then()` block ignores. So this wasn't actually waiting for the click
to occur.

This triggered a number of test bugs (caused by erroneous assumptions
accidentally baked into the tests. I fixed a few, and filed a few
bugs for the rest (after failing to figure out how to fix them).

Note that the WPT version of testdriver.js is rolled into Chromium,
so that change is being made here:
  web-platform-tests/wpt#49691

Bug: 384009734,384050894
Change-Id: Ibdb8a97d23998ad89c5a48c23a7e780dc605283b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6094526
Reviewed-by: Jonathan Lee <jonathanjleegoogle.com>
Auto-Submit: Mason Freed <masonfchromium.org>
Commit-Queue: Mason Freed <masonfchromium.org>
Commit-Queue: Jonathan Lee <jonathanjleegoogle.com>
Cr-Commit-Position: refs/heads/main{#1397010}

Co-authored-by: Mason Freed <masonfchromium.org>
--

wpt-commits: ce746b469d6c2fe11cf9db769eb2b3426bad6466
wpt-pr: 49719

UltraBlame original commit: 337b58e389432dc74cdafad2aeb85b1e0ea5fc3c

Author: marco-c

testing/web-platform/tests/fullscreen/rendering/backdrop-object.html

@@ -139,20 +139,6 @@
 +
 xml
 "
-data
-=
-"
-/
-images
-/
-100px
--
-green
--
-rect
-.
-svg
-"
 >
 <
 /
@@ -173,50 +159,105 @@
 "
 )
 ;
-Promise
+test_driver
 .
-all
+bless
+(
+'
+fullscreen
+'
+)
+.
+then
+(
+(
+)
+=
+>
+{
+object
+.
+data
+=
+"
+/
+images
+/
+100px
+-
+green
+-
+rect
+.
+svg
+"
+;
+}
+)
+.
+then
 (
-[
+(
+)
+=
+>
 new
 Promise
 (
 (
 resolve
-reject
 )
 =
 >
-document
+object
 .
 addEventListener
 (
 "
-fullscreenchange
+load
 "
 resolve
 )
 )
+)
+.
+then
+(
+(
+)
+=
+>
+object
+.
+requestFullscreen
+(
+)
+)
+.
+then
+(
+(
+)
+=
+>
 new
 Promise
 (
 (
 resolve
-reject
 )
 =
 >
-object
+document
 .
 addEventListener
 (
 "
-load
+fullscreenchange
 "
 resolve
 )
 )
-]
 )
 .
 then
@@ -241,24 +282,6 @@
 )
 )
 ;
-test_driver
-.
-bless
-(
-'
-fullscreen
-'
-(
-)
-=
->
-object
-.
-requestFullscreen
-(
-)
-)
-;
 <
 /
 script

testing/web-platform/tests/html/semantics/forms/the-input-element/show-picker-user-gesture.html

@@ -104,10 +104,6 @@
 body
 >
 <
-/
-body
->
-<
 script
 type
 =
@@ -126,20 +122,42 @@
 js
 "
 ;
-for
-(
+/
+/
+File
+pickers
+can
+'
+t
+be
+closed
+.
 const
-inputType
-of
+types
+=
 inputTypes
-)
-{
-test
+.
+filter
 (
 (
+t
 )
 =
 >
+t
+!
+=
+'
+file
+'
+)
+;
+function
+createElement
+(
+t
+type
+)
 {
 const
 input
@@ -160,6 +178,60 @@
 "
 type
 "
+type
+)
+;
+document
+.
+body
+.
+appendChild
+(
+input
+)
+;
+t
+.
+add_cleanup
+(
+(
+)
+=
+>
+input
+.
+remove
+(
+)
+)
+;
+return
+input
+;
+}
+for
+(
+const
+inputType
+of
+types
+)
+{
+promise_test
+(
+async
+(
+t
+)
+=
+>
+{
+const
+input
+=
+createElement
+(
+t
 inputType
 )
 ;
@@ -200,41 +272,21 @@
 gesture
 )
 ;
-}
-for
-(
-const
-inputType
-of
-inputTypes
-)
-{
 promise_test
 (
 async
+(
 t
+)
 =
 >
 {
 const
 input
 =
-document
-.
 createElement
 (
-"
-input
-"
-)
-;
-input
-.
-setAttribute
-(
-"
-type
-"
+t
 inputType
 )
 ;
@@ -283,42 +335,21 @@
 active
 )
 ;
-}
-for
-(
-const
-inputType
-of
-inputTypes
-)
-{
 promise_test
 (
 async
 (
+t
 )
 =
 >
 {
 const
 input
 =
-document
-.
 createElement
 (
-'
-input
-'
-)
-;
-input
-.
-setAttribute
-(
-'
-type
-'
+t
 inputType
 )
 ;

testing/web-platform/tests/resources/testdriver.js

@@ -666,14 +666,19 @@ button
 .
 then
 (
+(
+)
+=
+>
 wait_click
 )
 .
 then
 (
-function
 (
 )
+=
+>
 {
 button
 .