Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatize GitHub Workflows and Download pipeline #444

Open
dario-coscia opened this issue Feb 4, 2025 · 2 comments
Open

Automatize GitHub Workflows and Download pipeline #444

dario-coscia opened this issue Feb 4, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@dario-coscia
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
PINA needs to automatize and add new workflow:

  1. Formatter: We can add a test to check the code is right formatted. This would remove black-formatter.yml which adds to many commits to the repo history.
  2. testing_doc.yml
  3. Update from setup.py to pyproject.toml since it is becoming the standard. Maybe add the possibility to download pina with conda?
  4. Tests on GPUs are still missing
@dario-coscia dario-coscia added the enhancement New feature or request label Feb 4, 2025
@ndem0
Copy link
Member

ndem0 commented Feb 6, 2025

I do not understand the issue

  1. We have automatic formatting, would you like to disable it? Why?
  2. ???
  3. toml is already there in 0.2. For conda packaging it's better to discuss before.
  4. GPUs should not be used in GH Action, how do you plan?

@dario-coscia
Copy link
Collaborator Author

dario-coscia commented Feb 6, 2025

  1. We have automatic formatting, would you like to disable it? Why?
  2. ???
  3. toml is already there in 0.2. For conda packaging it's better to discuss before.
  4. GPUs should not be used in GH Action, how do you plan?
  1. Sorry for this, I haven't notice the change!
  2. This workflow usually fails, even if the doc is built. I don't know if it is actually an issue with the workflow or the documentation.
  3. Shall we open a discussion for conda?
  4. Github has large runners option but they are not free.. I don't think there are alternatives (rather than local testing with a GPU)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants