Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zksync-ethers SDK to support signing smart account transactions via external signers (e.g. Metamask) #12

Open
ly0va opened this issue Oct 16, 2024 · 1 comment

Comments

@ly0va
Copy link
Member

ly0va commented Oct 16, 2024

With K1 signer support added to the smart account, it should be possible to sign smart account transactions via Metamask.

However, zksync-ethers SDK's class SmartAccount provides an incorrect signature for its payloadSigner hook: it accepts a hash, whereas metamask expects an unhashed message (and hence hashes it again).

This makes it impossible to use external signers such as metamask with SmartAccount class.
The task is to fix it and test if it works.

@ly0va ly0va changed the title Update zksync SDK to support signing smart account transactions via external signers (e.g. Metamask) Update zksync-ethers SDK to support signing smart account transactions via external signers (e.g. Metamask) Oct 16, 2024
@MexicanAce
Copy link
Contributor

@ly0va Unsure this is an issue for this repo. Perhaps we should move this to https://github.com/zksync-sdk/zksync-ethers ?

@itsacoyote itsacoyote transferred this issue from matter-labs/zksync-sso-clave-contracts Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants