Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Chromiumoxide stopped working with the latest version of Chrome #243

Open
RiddleMan opened this issue Oct 4, 2024 · 5 comments · May be fixed by #246
Open

bug: Chromiumoxide stopped working with the latest version of Chrome #243

RiddleMan opened this issue Oct 4, 2024 · 5 comments · May be fixed by #246

Comments

@RiddleMan
Copy link

I found out that new version of Chrome (129.0.6668.90) is breaking a contract, because I ran an example wiki-tokio (cargo run --example wiki-tokio --features=tokio-runtime) and get the following errors:

➞  cargo run --example wiki-tokio --features=tokio-runtime                                                                                                                     [git:main] ✖
   Compiling chromiumoxide v0.7.0 (/Users/Artur_Ptaszek/Projects/chromiumoxide)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.12s
     Running `target/debug/examples/wiki-tokio`
2024-10-04T13:26:41.476856Z ERROR chromiumoxide::conn: Failed to deserialize WS response data did not match any variant of untagged enum Message
2024-10-04T13:26:41.476914Z ERROR chromiumoxide::handler: WS Connection error: Serde(Error("data did not match any variant of untagged enum Message", line: 0, column: 0))
2024-10-04T13:26:41.522487Z ERROR chromiumoxide::conn: Failed to deserialize WS response data did not match any variant of untagged enum Message
2024-10-04T13:26:41.522508Z ERROR chromiumoxide::handler: WS Connection error: Serde(Error("data did not match any variant of untagged enum Message", line: 0, column: 0))
2024-10-04T13:26:41.694697Z  WARN chromiumoxide::browser: Browser was not closed manually, it will be killed automatically in the background
Error: ChromeMessage("Node is either not visible or not an HTMLElement")

It stopped working in tool I maintain https://github.com/RiddleMan/doken . It fails on CI as well as on dev machines. I blame the version of Chrome, because I had it broken on my machine using doken, but my colleague said it was fine. After he updated a Chrome, then it stopped working for him as well. However, I provided simpler code to reproduce the problem.

@Sytten
Copy link
Contributor

Sytten commented Oct 23, 2024

I imagine they did a breaking change in the CDP, this is related to #197.
We should be able to handle breaking changes and skip over those messages.

@Cyberphinx
Copy link

I'm having exactly the same issue now. The error still persists even after downgrading chrome to a few different versions.

@Sytten
Copy link
Contributor

Sytten commented Nov 10, 2024

Its because we have not released the ignore of invalid messages most likely. See the PR.

@kuras120
Copy link

@Sytten any ETA of fix for this issue?

@Sytten
Copy link
Contributor

Sytten commented Jan 27, 2025

Its fixed on #246, just needs to be merged by @mattsse
You can use a fork @kuras120 thats what I do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants