Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harbor Should Ignore Commented ENV Keys #125

Open
mehrancodes opened this issue Jan 21, 2025 · 0 comments
Open

Harbor Should Ignore Commented ENV Keys #125

mehrancodes opened this issue Jan 21, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@mehrancodes
Copy link
Owner

When Harbor processes .env.example, it’s uncommenting lines like:

# DB_HOST=mariadb_1 # if you're using Sail
DB_HOST=127.0.0.1

We expect Harbor not to touch any commented-out env keys (the # DB_HOST line above).

Steps to Reproduce
1. Create or open a .env.example file with a commented-out variable (e.g., # DB_HOST=mariadb_1).
2. Run Harbor provisioning.
3. Notice that the previously commented line is now uncommented.

Expected Behavior
• Harbor should leave all commented lines as they are and only modify actual (uncommented) env keys.

Additional Context
• Any mention of # DB_HOST in .env.example (or similar) should remain commented after Harbor runs.
• This issue could affect any commented variables that the user wants to keep for reference but doesn’t currently need in their active configuration.

@mehrancodes mehrancodes added the bug Something isn't working label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant