Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README figure is low-res and transparent #106

Closed
talonchandler opened this issue Feb 22, 2023 · 2 comments · Fixed by #141
Closed

README figure is low-res and transparent #106

talonchandler opened this issue Feb 22, 2023 · 2 comments · Fixed by #141
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@talonchandler
Copy link
Collaborator

The latest README figure is lower resolution than the previous one, so the smallest text is barely legible:

Screen Shot 2023-02-22 at 11 00 20 AM

@ziw-liu also pointed out that the background is mostly transparent and inconsistent:

the equation in the figure is on a solid white background, while the rest of the figure is on a transparent background that may have contrast issues in a dark theme

@mattersoflight can you point me to the source file or fix these when you get a chance?

Note: this does not need to be fixed before the release, since I'm linking the github file directly (I learned through recOrder releases that linking the github file is a good strategy since distributing .pngs is suboptimal---no need to pip-install big pngs for everyone).

@talonchandler talonchandler changed the title README figure is low-res and transparent and low-res README figure is low-res and transparent Feb 23, 2023
@mattersoflight mattersoflight self-assigned this Mar 1, 2023
@ziw-liu ziw-liu added the documentation Improvements or additions to documentation label Apr 21, 2023
@mattersoflight
Copy link
Member

Sorry for the delay @talonchandler- here the source PDF on our google drive. The folder Figure_Apr2022 has all the other figures too.

@ziw-liu pointed me to the trick to show different images when the github theme changes, which I think is the way to go for all READMEs.

@ziw-liu
Copy link
Contributor

ziw-liu commented Jul 25, 2023

the trick to show different images when the github theme changes

Example in viscy: mehta-lab/VisCy#22 (comment)

Edit: for reference I generated those by applying Filters -> Color -> Invert -> Invert lightness in Inkscape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants