Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify the version of renovatebot used #178

Open
sp3nx0r opened this issue Jan 12, 2022 · 7 comments
Open

Ability to specify the version of renovatebot used #178

sp3nx0r opened this issue Jan 12, 2022 · 7 comments

Comments

@sp3nx0r
Copy link
Contributor

sp3nx0r commented Jan 12, 2022

We've run into a couple of instances where fixes to issues are available in the current release of renovatebot but not in the version that's packaged with renovate-on-prem. Looks like it's specified as a dependency in package.json so thought maybe it'd be as simple as bumping that and re-running yarn

FROM whitesource/renovate:1.6.2

USER root
WORKDIR /usr/src/app
RUN sed -i 's/27.31.10/31.23.3/g' package.json
RUN yarn install
USER ubuntu
ENTRYPOINT [ "docker-entrypoint.sh" ]

But that didn't quite do the trick. Not sure if others would find this useful, but a means use more recent renovatebot versions (either elegantly or via something like my hack above) would be real great.

@rarkins
Copy link
Member

rarkins commented Jan 16, 2022

One day we might be able to support this, but not soon. There might be a workaround similar to the above which works

@sp3nx0r
Copy link
Contributor Author

sp3nx0r commented Jan 16, 2022

Any insight into the packaging process for the onprem image or why the above wouldn’t necessarily work would be great for an “unsupported” workaround.

@rarkins
Copy link
Member

rarkins commented Jan 17, 2022

@sp3nx0r
Copy link
Contributor Author

sp3nx0r commented Jan 17, 2022

With the (soon to be) release of 2.1.0, the need for this is drastically less, but leaving this in case people find this useful.

FROM whitesource/renovate:1.6.2

# renovate: datasource=github-releases depName=renovatebot/renovate
ENV RENOVATEBOT_VERSION=31.28.3

USER root
WORKDIR /usr/src/app
RUN sed -i -e "s|\"renovate\": \"*.*.*\",|\"renovate\": \"$RENOVATEBOT_VERSION\",|" package.json
RUN yarn install --production && yarn cache clean
ENTRYPOINT [ "docker-entrypoint.sh" ]
CMD ["node", "src/server.js"]
EXPOSE 8080
USER 1000

Same Dockerfile will work on newest release as well, tested in our environment and works swell. Really jazzed about the new 2.x release!

@sp3nx0r sp3nx0r closed this as completed Jan 17, 2022
@sp3nx0r
Copy link
Contributor Author

sp3nx0r commented Mar 14, 2022

This no longer works due to renovatebot/renovate@dca3418 refactoring, so will need to pin to 31.x until the on-prem wrapper is updated for the refactor.

@sp3nx0r sp3nx0r reopened this Mar 14, 2022
@vladh91
Copy link

vladh91 commented Jan 5, 2023

I would love to see this implemented.Are there any updates on this? We are really blocked because we can't use newer version of renovatebot. It would be nice at least to have some kind of workaround(for an example have Dockerfile where we can change version and build docker image).

@sp3nx0r
Copy link
Contributor Author

sp3nx0r commented Jan 5, 2023

The above Dockerfile example still works, we're actively using it within our org for Renovate customization (which includes a custom helm s3 repo setup). If there are breaking changes to how the Renovate on-prem server startup is done (like in the comment I posted from March), it will break. But has been running smooth for us for quite some time now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants