Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmm change --force #492

Open
2 tasks done
morgantic opened this issue Nov 27, 2023 · 2 comments
Open
2 tasks done

mmm change --force #492

morgantic opened this issue Nov 27, 2023 · 2 comments
Labels
feature A new feature to add stale

Comments

@morgantic
Copy link

I have checked for similar

  • I have searched for my issue and did not find it

Not a bug

  • I swear this is an actual feature request

Why?

If there are non upgradeable mods found, the only way to upgrade to a newer version is either deleting the mod or having allowVersionFallback set to true, which is not always desirable (especially as long as it's a global setting)

What?

I think it would be great if there was a way to just --force a version change (with an additional confirmation "Yes, I know what I'm doing"?), so I can just easily bypass this without having to take mods out of the modlist and later re-adding them..

Any alternatives?

This would probably become obsolete by allowVersionFallback being per mod and/or test respecting the allowVersionFallback setting.
It would still be cool to have for other unexpected edge cases, I guess.

Anything else?

No response

@morgantic morgantic added the feature A new feature to add label Nov 27, 2023
@meza
Copy link
Owner

meza commented Dec 12, 2023

With the fix that went in the other day, this might also have been ... made better? ... the main source of the issues was the buggy/outright bad handling of the versionFallback mechanism. If you have time to test it with the new release, could you?

I'm fully on board with a --force, just trying to think of what it would do. If it doesn't do the verification of the versions, it would basically be a "remove all mods locally, change the version in the modlist.config and then attempt to install and see what happens"

I might still do it regardless but I'm curious if the fallback fix has helped with this situation

@meza meza modified the milestone: 1.3.0 Dec 21, 2023
Copy link

stale bot commented Dec 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature to add stale
Projects
None yet
Development

No branches or pull requests

2 participants