Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployer refactor #490

Open
BMurri opened this issue Sep 27, 2022 · 2 comments
Open

Deployer refactor #490

BMurri opened this issue Sep 27, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed tobegroomed Add this label while creating new issues to get issues prioritized on the backlog
Milestone

Comments

@BMurri
Copy link
Collaborator

BMurri commented Sep 27, 2022

Problem:
The Deployer class is, at this point, a god object, and it's getting worse.

Solution:
There are several things happening in the ~3k loc, most of which should be moved into sibling classes.

Describe alternatives you've considered
Continuing to add more and more cruft.

Additional context
There are some sibling classes now, but there's no consistency in the relationships between the various parts. Some thoughtful design should be brought to bear here so that continued innovations won't be hampered by the difficulty of grokking the mess.

@BMurri BMurri added enhancement New feature or request help wanted Extra attention is needed needs discussion Team discussion is needed labels Sep 27, 2022
@BMurri BMurri added this to the backlog milestone Sep 27, 2022
@olesya13 olesya13 removed the needs discussion Team discussion is needed label Sep 30, 2022
@ngambani
Copy link

ngambani commented Feb 1, 2024

@BMurri does this problem still exist? or has been resolved/not required anymore?

@BMurri
Copy link
Collaborator Author

BMurri commented Feb 2, 2024

It is still needed.

@ngambani ngambani added the tobegroomed Add this label while creating new issues to get issues prioritized on the backlog label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed tobegroomed Add this label while creating new issues to get issues prioritized on the backlog
Projects
None yet
Development

No branches or pull requests

3 participants