Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always trim '?' from the start of SAS tokens #638

Closed
MattMcL4475 opened this issue Apr 10, 2023 · 0 comments · Fixed by microsoft/ga4gh-tes#195 or #639
Closed

Always trim '?' from the start of SAS tokens #638

MattMcL4475 opened this issue Apr 10, 2023 · 0 comments · Fixed by microsoft/ga4gh-tes#195 or #639
Assignees
Labels
Bug Something isn't working

Comments

@MattMcL4475
Copy link
Contributor

MattMcL4475 commented Apr 10, 2023

Azure Storage Explorer includes the '?' at the beginning of a SAS token.
Azure Portal does NOT include the '?'.

Throughput the CoA and TES code, the system shall always TrimStart('?') of SAS tokens, in case they are included, to avoid "??" double quotation issues, which can lead to inconsistent and difficult to find bugs.

This bug is to add the equivalent of TrimStart('?') to every area in the entire code base that uses SAS tokens and/or refactor all of uses of a SAS token to a single utility library that does it.

@MattMcL4475 MattMcL4475 added the Bug Something isn't working label Apr 10, 2023
@ashanhol ashanhol self-assigned this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants