Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests should delete jobs whenever they delete pools #718

Closed
BMurri opened this issue Oct 18, 2023 · 0 comments · Fixed by #719
Closed

Integration tests should delete jobs whenever they delete pools #718

BMurri opened this issue Oct 18, 2023 · 0 comments · Fixed by #719
Assignees

Comments

@BMurri
Copy link
Contributor

BMurri commented Oct 18, 2023

Describe the bug
In TES's current Azure Batch usage pattern, every pool has exactly one matching job. In batch, those are separate entities, and deleting one does not cause the deletion of the other (unless the creating TES instance is still running, in which case it will delete items who's partner "disappears" unexpectedly). That leaves jobs that have to be cleaned up manually later on.

Steps to Reproduce
Use a batch account for a while with several resource groups.
Delete those resource groups. (order of these first two can be intermixed with various RGs).
Note the number of pools and jobs.
Run the test IntegrationTests.DeleteOldBatchPoolsAsync from TriggerService.Tests and wait 5 minutes.
Note that the number of jobs remains the same, while the number of pools has diminished.

Expected behavior
Pools and jobs would be deleted together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant